flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...
Date Wed, 27 Sep 2017 11:45:56 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4728#discussion_r141318269
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -228,55 +245,55 @@ public WebRuntimeMonitor(
     		} else {
     			serverSSLContext = null;
     		}
    -		metricFetcher = new MetricFetcher(retriever, queryServiceRetriever, executor, timeout);
    +		metricFetcher = new MetricFetcher(retriever, queryServiceRetriever, scheduledExecutor,
timeout);
     
     		String defaultSavepointDir = config.getString(CoreOptions.SAVEPOINT_DIRECTORY);
     
    -		JobCancellationWithSavepointHandlers cancelWithSavepoint = new JobCancellationWithSavepointHandlers(currentGraphs,
executor, defaultSavepointDir);
    +		JobCancellationWithSavepointHandlers cancelWithSavepoint = new JobCancellationWithSavepointHandlers(executionGraphCache,
scheduledExecutor, defaultSavepointDir);
     		RuntimeMonitorHandler triggerHandler = handler(cancelWithSavepoint.getTriggerHandler());
     		RuntimeMonitorHandler inProgressHandler = handler(cancelWithSavepoint.getInProgressHandler());
     
     		Router router = new Router();
     		// config how to interact with this web server
    -		get(router, new DashboardConfigHandler(executor, cfg.getRefreshInterval()));
    +		get(router, new DashboardConfigHandler(scheduledExecutor, cfg.getRefreshInterval()));
    --- End diff --
    
    But it's not necessarily about reducing the diff if the name change makes it clearer what
this object is.


---

Mime
View raw message