flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling
Date Wed, 27 Sep 2017 09:46:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182267#comment-16182267
] 

ASF GitHub Bot commented on FLINK-7076:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r141293920
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile resourceProfile) {
     
     	@Override
     	public void stopWorker(ResourceID resourceID) {
    -		// TODO: Implement to stop the worker
    +		ContainerId containerId = containerIdMap.remove(resourceID.getResourceIdString());
    +		if (containerId != null) {
    +			log.info("Stopping container {}.", containerId.toString());
    +			resourceManagerClient.releaseAssignedContainer(containerId);
    --- End diff --
    
    I think in the Yarn case, the `resourceID` is generated from the stringified version of
the `containerId`. Thus, you should be able to retrieve it from the provided `resourceID`.


> Implement container release to support dynamic scaling
> ------------------------------------------------------
>
>                 Key: FLINK-7076
>                 URL: https://issues.apache.org/jira/browse/FLINK-7076
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Shuyi Chen
>              Labels: flip-6
>
> In order to support dynamic scaling, the {{YarnResourceManager}} has to be able to dynamically
free containers. We have to implement the {{YarnResourceManager#stopWorker}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message