flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling
Date Wed, 27 Sep 2017 09:46:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182266#comment-16182266
] 

ASF GitHub Bot commented on FLINK-7076:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r141294374
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile resourceProfile) {
     
     	@Override
     	public void stopWorker(ResourceID resourceID) {
    --- End diff --
    
    I actually think that we should refactor this method to take a parameter of generic type
`WorkerType` which contains all the framework specific registration information. In the current
`YarnResourceManager` implementation case, it would be `ResourceID` which is generated from
the container id. Thus, we should be able to retrieve the `containerId` from it.


> Implement container release to support dynamic scaling
> ------------------------------------------------------
>
>                 Key: FLINK-7076
>                 URL: https://issues.apache.org/jira/browse/FLINK-7076
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Shuyi Chen
>              Labels: flip-6
>
> In order to support dynamic scaling, the {{YarnResourceManager}} has to be able to dynamically
free containers. We have to implement the {{YarnResourceManager#stopWorker}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message