flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers
Date Thu, 14 Sep 2017 13:48:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166331#comment-16166331

ASF GitHub Bot commented on FLINK-7378:

Github user NicoK commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
    @@ -333,7 +333,7 @@ public void updateInputChannel(InputChannelDeploymentDescriptor icdd)
throws IOE
     			InputChannel current = inputChannels.get(partitionId);
    -			if (current.getClass() == UnknownInputChannel.class) {
    +			if (current instanceof UnknownInputChannel) {
    --- End diff --
    Just to be on the safe side, you should also change this check in `#setInputChannel()`
above. This way, we handle all sub-classes of `UnknownInputChannel` the same way as `UnknownInputChannel`

> Create a fix size (non rebalancing) buffer pool type for the floating buffers
> -----------------------------------------------------------------------------
>                 Key: FLINK-7378
>                 URL: https://issues.apache.org/jira/browse/FLINK-7378
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
> Currently the number of network buffers in {{LocalBufferPool}} for {{SingleInputGate}}
is limited by {{a * <number of channels> + b}}, where a is the number of exclusive buffers
for each channel and b is the number of floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to create a fix size buffer
pool used to manage the floating buffers for {{SingleInputGate}}. And the exclusive buffers
are assigned to {{InputChannel}}s directly.

This message was sent by Atlassian JIRA

View raw message