flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL
Date Thu, 14 Sep 2017 13:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166288#comment-16166288
] 

ASF GitHub Bot commented on FLINK-7491:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4585#discussion_r138888586
  
    --- Diff: flink-core/pom.xml ---
    @@ -80,6 +80,13 @@ under the License.
     			<!-- managed version -->
     		</dependency>
     
    +		<!-- For multiset -->
    +		<dependency>
    +			<groupId>org.apache.commons</groupId>
    --- End diff --
    
    We should not add additional dependencies to Flink just because of a new data type. There
is also no reason behind choosing this library. Couldn't we not just use a usual Java Map?
Otherwise I would propose to add class for our own type like we did it for `org.apache.flink.types.Row`.
Calcite is using `List`, which is not very nice, but would also work.


> Support COLLECT Aggregate function in Flink SQL
> -----------------------------------------------
>
>                 Key: FLINK-7491
>                 URL: https://issues.apache.org/jira/browse/FLINK-7491
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message