flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL
Date Wed, 20 Sep 2017 16:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173485#comment-16173485
] 

ASF GitHub Bot commented on FLINK-7491:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4585#discussion_r140026944
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/AggregateITCase.scala
---
    @@ -329,6 +329,35 @@ class AggregateITCase(
       }
     
       @Test
    +  def testTumbleWindowAggregateWithCollect(): Unit = {
    +
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +
    +    val sqlQuery =
    +      "SELECT b, COLLECT(b)" +
    --- End diff --
    
    Collect should be added to the [SQL documentation](https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/table/sql.html#built-in-functions)
under "Built-in Function" -> "Aggregate Functions"
    
    Moreover, we should add `MULTISET` to the [supported data types](https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/table/sql.html#data-types).
    
    It would also be nice if you could open a JIRA to add support for COLLECT to the Table
API. We try to keep both in sync and it helps if we have a list of things that need to be
added.


> Support COLLECT Aggregate function in Flink SQL
> -----------------------------------------------
>
>                 Key: FLINK-7491
>                 URL: https://issues.apache.org/jira/browse/FLINK-7491
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message