flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL
Date Tue, 26 Sep 2017 16:44:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181116#comment-16181116
] 

ASF GitHub Bot commented on FLINK-7491:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4585#discussion_r141111022
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -1414,8 +1414,29 @@ object AggregateUtil {
               aggregates(index) = udagg.getFunction
               accTypes(index) = udagg.accType
     
    -        case unSupported: SqlAggFunction =>
    -          throw new TableException(s"unsupported Function: '${unSupported.getName}'")
    +        case other: SqlAggFunction =>
    --- End diff --
    
    Change this case to `case collect: SqlAggFunction if collect.getKind == SqlKind.COLLECT
=>` to have a dedicated case for this built-in function. Also the case after `case _: SqlCountAggFunction`
to have all built-in functions together.


> Support COLLECT Aggregate function in Flink SQL
> -----------------------------------------------
>
>                 Key: FLINK-7491
>                 URL: https://issues.apache.org/jira/browse/FLINK-7491
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message