flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7564) Fix Watermark semantics in Table API
Date Fri, 01 Sep 2017 08:21:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150193#comment-16150193

ASF GitHub Bot commented on FLINK-7564:

GitHub user xccui opened a pull request:


    [FLINK-7564] [table] Fix Watermark semantics in RowTimeUnboundedOver

    ## What is the purpose of the change
    This PR aims to fix the watermark boundary check problem (mentioned in [this thread](https://lists.apache.org/thread.html/3541e72ba3842192e58a487e54c2817f6b2b9d12af5fee97af83e5df@%3Cdev.flink.apache.org%3E.))
in Table API.
    ## Brief change log
    - Change the delay-condition for rows in RowTimeUnboundedOver to <= watermark.
    - Add some tests for late data in OverWindowHarnessTest.
    ## Verifying this change
    This change is already covered by OverWindowHarnessTest.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (N/A)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7564

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4633
commit 5312ac421384436d7170d8f1c2e00aba9e670044
Author: Xingcan Cui <xingcanc@gmail.com>
Date:   2017-09-01T01:16:21Z

    [FLINK-7564] [table] Fix Watermark semantics in Table API


> Fix Watermark semantics in Table API
> ------------------------------------
>                 Key: FLINK-7564
>                 URL: https://issues.apache.org/jira/browse/FLINK-7564
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Aljoscha Krettek
>            Assignee: Xingcan Cui
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.3
> For reference, see https://lists.apache.org/thread.html/3541e72ba3842192e58a487e54c2817f6b2b9d12af5fee97af83e5df@%3Cdev.flink.apache.org%3E.

This message was sent by Atlassian JIRA

View raw message