flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7571) Execution of TableSources with Time Indicators fails
Date Fri, 01 Sep 2017 20:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151088#comment-16151088
] 

ASF GitHub Bot commented on FLINK-7571:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4635

    [FLINK-7571] [table] Fix translation of TableSource with time indicators

    ## What is the purpose of the change
    
    This PR fixes the translation / code generation for table scans against table sources
that include tiem indicator fields. The behavior was broken during the recent time indicator
refactoring.
    I added a test to ensure the feature remains working.
    
    ## Brief change log
    
    - Add an ITCase to ensure that table sources with time indicators are correctly executed
    - Fix the registration of table sources with time indicators
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    Run `TimeAttributesITCase.testTableSourceWithTimeIndicators()`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableTSFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4635
    
----
commit c7f6d069c8224ee756bcbd66305ad84d2a7ac8d3
Author: Fabian Hueske <fhueske@apache.org>
Date:   2017-09-01T19:41:21Z

    [FLINK-7571] [table] Fix translation of TableSource with time indicators.

----


> Execution of TableSources with Time Indicators fails
> ----------------------------------------------------
>
>                 Key: FLINK-7571
>                 URL: https://issues.apache.org/jira/browse/FLINK-7571
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Critical
>
> The translation of queries that include a TableSource with time indicators fails during
the code generation because field names and field indicies are not adjusted for the time indicators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message