flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7581) Name netty threads of rest components
Date Wed, 06 Sep 2017 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154974#comment-16154974
] 

ASF GitHub Bot commented on FLINK-7581:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4644#discussion_r137198747
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
---
    @@ -104,8 +105,8 @@ protected void initChannel(SocketChannel ch) {
     			}
     		};
     
    -		NioEventLoopGroup bossGroup = new NioEventLoopGroup(1);
    -		NioEventLoopGroup workerGroup = new NioEventLoopGroup();
    +		NioEventLoopGroup bossGroup = new NioEventLoopGroup(1, new DefaultThreadFactory("flink-rest-server-netty-boss"));
    +		NioEventLoopGroup workerGroup = new NioEventLoopGroup(1, new DefaultThreadFactory("flink-rest-server-netty-worker"));
     
    --- End diff --
    
    Why setting the worker group thread pool size to 1? Leaving it to 0 will give you `Runtime.getRuntime().availableProcessors()
* 2`.


> Name netty threads of rest components
> -------------------------------------
>
>                 Key: FLINK-7581
>                 URL: https://issues.apache.org/jira/browse/FLINK-7581
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message