flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7583) Create singleton isntance for the content type header
Date Wed, 06 Sep 2017 14:11:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155404#comment-16155404
] 

ASF GitHub Bot commented on FLINK-7583:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4646
  
    I went through all usages of `HttpHeaders.Names.CONTENT_TYPE` and they are all related
to rest operators, making `RestContants` a good place to put them. Also, ConfigConstants should
be reserved for constants related to the configuration of Flink, which this isn't. Lastly,
many of these usage will be eclipsed in the near future anyway.


> Create singleton isntance for the content type header
> -----------------------------------------------------
>
>                 Key: FLINK-7583
>                 URL: https://issues.apache.org/jira/browse/FLINK-7583
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> The content type header for all rest requests/responses is always the same, but we currently
allocate a separate string for each request/response. We should instead use a static constant.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message