flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder
Date Tue, 26 Sep 2017 17:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181182#comment-16181182
] 

ASF GitHub Bot commented on FLINK-7668:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4728#discussion_r141125073
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
    @@ -38,5 +44,36 @@
     	 * @param timeout for this operation
     	 * @return Future REST endpoint address
     	 */
    -	CompletableFuture<String> requestRestAddress(Time timeout);
    +	CompletableFuture<String> requestRestAddress(@RpcTimeout  Time timeout);
    +
    +	/**
    +	 * Requests the AccessExecutionGraph for the given jobId. If there is no such graph,
then
    +	 * the future is completed with a {@link JobNotFoundException}.
    +	 *
    +	 * @param jobId identifying the job whose AccessExecutionGraph is requested
    +	 * @param timeout for the asynchronous operation
    +	 * @return Future containing the AccessExecutionGraph for the given jobId, otherwise
{@link JobNotFoundException}
    +	 */
    +	CompletableFuture<AccessExecutionGraph> requestJob(JobID jobId, @RpcTimeout Time
timeout);
    --- End diff --
    
    Well this seems questionable. These methods technically aren't related to being a restful
gateway,
    
    This seems like an odd attempt to reduce code duplication by just moving the code one
layer up without other considerations.


> Add AccessExecutionGraph refresh interval to ExecutionGraphHolder
> -----------------------------------------------------------------
>
>                 Key: FLINK-7668
>                 URL: https://issues.apache.org/jira/browse/FLINK-7668
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> Once we support offline {{AccessExecutionGraph}} implementation (see FLINK-7667) we should
add a refresh interval to the {{ExecutionGraphHolder}} after which the {{AccessExecutionGraph}}
is retrieved again from the {{JobMaster}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message