flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7678) SQL UserDefineTableFunction does not take CompositeType input correctly
Date Tue, 26 Sep 2017 11:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180629#comment-16180629
] 

ASF GitHub Bot commented on FLINK-7678:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/4726

    [FLINK-7678] [table] Support composite inputs for user-defined functions

    ## What is the purpose of the change
    
    This PR adds tests for rows as inputs for TableFunctions and ScalarFunctions.
    
    ## Brief change log
    
    Tests added
    
    
    ## Verifying this change
    
    This change added tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-7678

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4726
    
----
commit 2ad9bab75e7e61120b4e5fee4141fd6ffc59d75d
Author: twalthr <twalthr@apache.org>
Date:   2017-09-26T10:10:33Z

    [FLINK-7678] [table] Support composite inputs for user-defined functions

----


> SQL UserDefineTableFunction does not take CompositeType input correctly
> -----------------------------------------------------------------------
>
>                 Key: FLINK-7678
>                 URL: https://issues.apache.org/jira/browse/FLINK-7678
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.3.2
>            Reporter: Rong Rong
>            Assignee: Timo Walther
>
> UDF is using FlinkTypeFactory to infer operand type while UDTF does not go through the
same code path. This result in:
> {code:console}
> org.apache.flink.table.api.ValidationException: SQL validation failed. From line 1, column
38 to line 1, column 44: No match found for function signature func(<COMPOSITE(Row(f0:
Integer, f1: String))>) 
> Caused by: org.apache.calcite.runtime.CalciteContextException: From line 1, column 38
to line 1, column 44: No match found for function signature func(<COMPOSITE(Row(f0: Integer,
f1: String))>)
> {code}
> Please see github code for more info:
> https://github.com/walterddr/flink/blob/bug_report/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/UDTFCompositeTypeTestFailure.scala



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message