flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend
Date Wed, 27 Sep 2017 08:21:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182174#comment-16182174
] 

ASF GitHub Bot commented on FLINK-7683:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4722#discussion_r141272559
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
---
    @@ -37,6 +39,12 @@
     	void setCurrentKey(K newKey);
     
     	/**
    +	 * @return Stream of existing keys in the namespace.
    --- End diff --
    
    Nit: This could be changed to "Returns a stream of all keys for the given state and namespace.".
The first parameter should be renamed to `state` or something like it because `field` is not
used anywhere else, I think.


> Add method to iterate over all of the existing keys in a statebackend
> ---------------------------------------------------------------------
>
>                 Key: FLINK-7683
>                 URL: https://issues.apache.org/jira/browse/FLINK-7683
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>
> This is required to make possible preserving backward compatibility while changing state
definition of a keyed state operator (to do so operator must iterate over all of the existing
keys and rewrites them into a new state variable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message