flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4635: [FLINK-7571] [table] Fix translation of TableSourc...
Date Fri, 01 Sep 2017 20:12:52 GMT
GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4635

    [FLINK-7571] [table] Fix translation of TableSource with time indicators

    ## What is the purpose of the change
    
    This PR fixes the translation / code generation for table scans against table sources
that include tiem indicator fields. The behavior was broken during the recent time indicator
refactoring.
    I added a test to ensure the feature remains working.
    
    ## Brief change log
    
    - Add an ITCase to ensure that table sources with time indicators are correctly executed
    - Fix the registration of table sources with time indicators
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    Run `TimeAttributesITCase.testTableSourceWithTimeIndicators()`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableTSFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4635
    
----
commit c7f6d069c8224ee756bcbd66305ad84d2a7ac8d3
Author: Fabian Hueske <fhueske@apache.org>
Date:   2017-09-01T19:41:21Z

    [FLINK-7571] [table] Fix translation of TableSource with time indicators.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message