From issues-return-133073-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Wed Sep 27 19:52:06 2017 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FAF510710 for ; Wed, 27 Sep 2017 19:52:06 +0000 (UTC) Received: (qmail 3482 invoked by uid 500); 27 Sep 2017 19:52:06 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 3441 invoked by uid 500); 27 Sep 2017 19:52:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 3430 invoked by uid 99); 27 Sep 2017 19:52:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 19:52:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 76CE91813BD for ; Wed, 27 Sep 2017 19:52:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VE2E0dLH084j for ; Wed, 27 Sep 2017 19:52:04 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 2CB905FB0B for ; Wed, 27 Sep 2017 19:52:04 +0000 (UTC) Received: (qmail 3287 invoked by uid 99); 27 Sep 2017 19:52:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 19:52:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 12DE2F5BA5; Wed, 27 Sep 2017 19:52:02 +0000 (UTC) From: suez1224 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf... Content-Type: text/plain Message-Id: <20170927195203.12DE2F5BA5@git1-us-west.apache.org> Date: Wed, 27 Sep 2017 19:52:02 +0000 (UTC) Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141449807 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions.aggfunctions + +import java.lang.{Iterable => JIterable} +import java.util +import java.util.function.BiFunction + +import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation} +import org.apache.flink.api.java.typeutils._ +import org.apache.flink.table.api.dataview.MapView +import org.apache.flink.table.dataview.MapViewTypeInfo +import org.apache.flink.table.functions.AggregateFunction + + +/** The initial accumulator for Collect aggregate function */ +class CollectAccumulator[E](var f0:MapView[E, Integer]) { + def this() { + this(null) + } + + def canEqual(a: Any) = a.isInstanceOf[CollectAccumulator[E]] + + override def equals(that: Any): Boolean = + that match { + case that: CollectAccumulator[E] => that.canEqual(this) && this.f0 == that.f0 + case _ => false + } +} + +abstract class CollectAggFunction[E] + extends AggregateFunction[util.Map[E, Integer], CollectAccumulator[E]] { + + override def createAccumulator(): CollectAccumulator[E] = { + val acc = new CollectAccumulator[E](new MapView[E, Integer]( + getValueTypeInfo.asInstanceOf[TypeInformation[E]], BasicTypeInfo.INT_TYPE_INFO)) + acc + } + + def accumulate(accumulator: CollectAccumulator[E], value: E): Unit = { + if (value != null) { + if (accumulator.f0.contains(value)) { --- End diff -- Good catch. done. ---