flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4928: [FLINK-7732][kafka-consumer] Do not commit to kafk...
Date Wed, 01 Nov 2017 10:01:45 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4928#discussion_r148220943
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionState.java
---
    @@ -95,6 +95,10 @@ public final boolean isOffsetDefined() {
     		return offset != KafkaTopicPartitionStateSentinel.OFFSET_NOT_SET;
     	}
     
    +	public final boolean isSentinel() {
    --- End diff --
    
    In new approach method was dropped


---

Mime
View raw message