flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...
Date Wed, 01 Nov 2017 10:28:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4872#discussion_r148226047
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
---
    @@ -166,4 +169,12 @@ void notifySlotAvailable(
     	 * @return Future containing the resource overview
     	 */
     	CompletableFuture<ResourceOverview> requestResourceOverview(@RpcTimeout Time timeout);
    +
    +	/**
    +	 * Requests the paths for the TaskManager's {@link MetricQueryService} to query.
    +	 *
    +	 * @param timeout for the asynchronous operation
    +	 * @return Future containing the collection of instance ids and the corresponding metric
query service path
    --- End diff --
    
    Good catch.


---

Mime
View raw message