flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...
Date Wed, 01 Nov 2017 10:31:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4872#discussion_r148226738
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
    @@ -163,12 +156,14 @@ public JobLeaderService getJobLeaderService() {
     	 *
     	 * @param resourceID resource ID of the task manager
     	 * @param taskManagerServicesConfiguration task manager configuration
    +	 * @param metricRegistry to register the TaskManagerMetricGroup
     	 * @return task manager components
     	 * @throws Exception
     	 */
     	public static TaskManagerServices fromConfiguration(
    --- End diff --
    
    True, I'll pull the `TaskManagerMetricGroup` instantiation out of the `TaskManagerServices#fromConfiguration`.


---

Mime
View raw message