flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...
Date Wed, 01 Nov 2017 10:32:33 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4915#discussion_r148226920
  
    --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
    @@ -61,7 +61,7 @@
      * IT cases for the {@link FlinkKafkaProducer011}.
      */
     @SuppressWarnings("serial")
    -public class FlinkKafkaProducer011Tests extends KafkaTestBase {
    +public class FlinkKafkaProducer011Test extends KafkaTestBase {
    --- End diff --
    
    I haven't looked into too many `ITCase`s but coding guidelines require unit tests to be
subsecond execution speed:
    >Please use unit tests to test isolated functionality, such as methods. Unit tests
should execute in subseconds and should be preferred whenever possible. The name of unit test
classes have to on *Test. Use integration tests to implement long-running tests.
    
    http://flink.apache.org/contribute-code.html#coding-guidelines
    
    Then again, I don't know how consistent the tests are.


---

Mime
View raw message