flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...
Date Thu, 02 Nov 2017 17:25:25 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4937#discussion_r148599674
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPoolGateway.java
---
    @@ -86,10 +85,16 @@
     	// ------------------------------------------------------------------------
     
     	CompletableFuture<SimpleSlot> allocateSlot(
    -			ScheduledUnit task,
    +			AllocationID allocationID,
     			ResourceProfile resources,
     			Iterable<TaskManagerLocation> locationPreferences,
     			@RpcTimeout Time timeout);
     
     	void returnAllocatedSlot(Slot slot);
    +
    +	/**
    +	 * Cancel a slot allocation.
    +	 * This method should be called when the CompletableFuture returned by allocateSlot
completed exceptionally.
    --- End diff --
    
    Params description is missing.


---

Mime
View raw message