flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHand...
Date Thu, 02 Nov 2017 17:48:24 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4757#discussion_r148610350
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java
---
    @@ -120,6 +121,16 @@ public synchronized ComponentMetricStore getJobMetricStore(String
jobID) {
     	}
     
     	/**
    +	 * Returns the {@link ComponentMetricStore} for the given job ID.
    +	 *
    +	 * @param jobID job ID
    +	 * @return ComponentMetricStore for the given ID, or null if no store for the given
argument exists
    +	 */
    +	public synchronized ComponentMetricStore getJobMetricStore(JobID jobID) {
    +		return jobID == null ? null : ComponentMetricStore.unmodifiable(jobs.get(jobID.toString()));
    --- End diff --
    
    `jobID` should not be nullable.


---

Mime
View raw message