flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shuai-xu <...@git.apache.org>
Subject [GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...
Date Fri, 03 Nov 2017 07:15:40 GMT
Github user shuai-xu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4937#discussion_r148718854
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java
---
    @@ -262,23 +263,36 @@ public void disconnectResourceManager() {
     	// ------------------------------------------------------------------------
     
     	@Override
    -	public CompletableFuture<SimpleSlot> allocateSlot(
    -			ScheduledUnit task,
    --- End diff --
    
    Why put the ScheduledUnit as a parameter here? I think the interface in slot pool should
be clean and it should only have resource related parameters, should not have schedule related
parameters.


---

Mime
View raw message