flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...
Date Fri, 10 Nov 2017 13:14:31 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4993#discussion_r150230620
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
    @@ -166,27 +168,39 @@ public String getClientName() {
     	 *
     	 * <p>After a call to this method, all returned futures will be failed.
     	 */
    -	public void shutdown() {
    +	public CompletableFuture<Boolean> shutdown() {
    --- End diff --
    
    This method when being called twice will give you a wrong result. The second call will
immediately return you a completed future.


---

Mime
View raw message