flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...
Date Fri, 10 Nov 2017 14:09:20 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4993#discussion_r150243346
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
    @@ -260,25 +262,47 @@ private boolean attemptToBind(final int port) throws Throwable {
     	/**
     	 * Shuts down the server and all related thread pools.
     	 */
    -	public void shutdown() {
    -		LOG.info("Shutting down server {} @ {}", serverName, serverAddress);
    -
    -		if (handler != null) {
    -			handler.shutdown();
    -			handler = null;
    -		}
    -
    -		if (queryExecutor != null) {
    -			queryExecutor.shutdown();
    -		}
    +	public CompletableFuture<?> shutdownServer(Time timeout) throws InterruptedException
{
    +		log.info("Shutting down {} @ {}", serverName, serverAddress);
    +
    +		final CompletableFuture<Boolean> queryExecShutdownFuture = CompletableFuture.supplyAsync(()
-> {
    +				try {
    +					if (queryExecutor != null && !queryExecutor.isShutdown()) {
    +						queryExecutor.shutdown();
    +						queryExecutor.awaitTermination(timeout.toMilliseconds(), TimeUnit.MILLISECONDS);
    +						return true;
    +					}
    +				} catch (InterruptedException e) {
    +					log.warn("Failed to shutdown {}: ", serverName, e);
    +					return false;
    +				}
    +				return false;
    --- End diff --
    
    We want to avoid pulling in the dependency of `runtime` here. Does it make sense to move
the `Executors` to another module, e.g. `core`.


---

Mime
View raw message