flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7515) allow actual 0-length content in NettyMessage#allocateBuffer()
Date Wed, 01 Nov 2017 10:10:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233880#comment-16233880
] 

ASF GitHub Bot commented on FLINK-7515:
---------------------------------------

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4592
  
    LGTM (besides "Conflicting files")


> allow actual 0-length content in NettyMessage#allocateBuffer()
> --------------------------------------------------------------
>
>                 Key: FLINK-7515
>                 URL: https://issues.apache.org/jira/browse/FLINK-7515
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> Previously, length {{0}} meant "unknown content length" but there are cases where the
actual length is 0 and we do not need a larger buffer. Let's use {{-1}} for tagging the special
case instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message