flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7694) Port JobMetricsHandler to new REST handler
Date Thu, 02 Nov 2017 17:49:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236245#comment-16236245
] 

ASF GitHub Bot commented on FLINK-7694:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4757#discussion_r148604078
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -304,22 +304,21 @@ public WebRuntimeMonitor(
     		get(router, new JobAccumulatorsHandler(executionGraphCache, scheduledExecutor));
     
     		get(router, new TaskManagersHandler(scheduledExecutor, DEFAULT_REQUEST_TIMEOUT, metricFetcher));
    -		get(router,
    -			new TaskManagerLogHandler(
    -				retriever,
    -				scheduledExecutor,
    -				localRestAddress,
    -				timeout,
    -				TaskManagerLogHandler.FileMode.LOG,
    -				config));
    -		get(router,
    -			new TaskManagerLogHandler(
    -				retriever,
    -				scheduledExecutor,
    -				localRestAddress,
    -				timeout,
    -				TaskManagerLogHandler.FileMode.STDOUT,
    -				config));
    +		get(router, new TaskManagerLogHandler(
    +							retriever,
    +							scheduledExecutor,
    +							localRestAddress,
    +							timeout,
    +							TaskManagerLogHandler.FileMode.LOG,
    +							config));
    +		get(router, new TaskManagerLogHandler(
    +							retriever,
    +							scheduledExecutor,
    +							localRestAddress,
    +							timeout,
    +							TaskManagerLogHandler.FileMode.STDOUT,
    +							config));
    --- End diff --
    
    Please revert formatting changes.


> Port JobMetricsHandler to new REST handler
> ------------------------------------------
>
>                 Key: FLINK-7694
>                 URL: https://issues.apache.org/jira/browse/FLINK-7694
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message