flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7694) Port JobMetricsHandler to new REST handler
Date Thu, 02 Nov 2017 17:49:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236250#comment-16236250
] 

ASF GitHub Bot commented on FLINK-7694:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4757#discussion_r148610350
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java
---
    @@ -120,6 +121,16 @@ public synchronized ComponentMetricStore getJobMetricStore(String
jobID) {
     	}
     
     	/**
    +	 * Returns the {@link ComponentMetricStore} for the given job ID.
    +	 *
    +	 * @param jobID job ID
    +	 * @return ComponentMetricStore for the given ID, or null if no store for the given
argument exists
    +	 */
    +	public synchronized ComponentMetricStore getJobMetricStore(JobID jobID) {
    +		return jobID == null ? null : ComponentMetricStore.unmodifiable(jobs.get(jobID.toString()));
    --- End diff --
    
    `jobID` should not be nullable.


> Port JobMetricsHandler to new REST handler
> ------------------------------------------
>
>                 Key: FLINK-7694
>                 URL: https://issues.apache.org/jira/browse/FLINK-7694
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message