flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7974) AbstractServerBase#shutdown does not wait for shutdown completion
Date Fri, 10 Nov 2017 11:20:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247362#comment-16247362
] 

ASF GitHub Bot commented on FLINK-7974:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/4993

    [FLINK-7974][FLINK-7975][QS] Wait for shutdown in QS client and servers.

    ## What is the purpose of the change
    
    Previously we were freeing the resources held by the QS client and servers on `shutdown()`,
but we were not waiting for this to complete. Now we are waiting for everything to be freed.
    
    ## Brief change log
    
    The `Client` and the `AbstractServerBase` contain the biggest changes. The actual implementations
(`KvStateClientProxyImpl`, `KvStateServerImpl`, and `QueryableStateClient`) build on that.
    
    ## Verifying this change
    
    Some tests were also adjusted but mainly the changes are tested in `AbstractServerTest`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): NO
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: NO
      - The serializers: NO
      - The runtime per-record code paths (performance sensitive): NO
      - Anything that affects deployment or recovery: NO
      - The S3 file system connector: NO
    
    ## Documentation
    
      - Does this pull request introduce a new feature? NO
      - If yes, how is the feature documented? not applicable
    
    R @aljoscha or @tillrohrmann 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink qs-shutdown-fin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4993
    
----
commit 46bced58030a76d65163369b58f9c02c814a4e08
Author: kkloudas <kkloudas@gmail.com>
Date:   2017-11-09T18:21:43Z

    [FLINK-7975][QS] Wait for QS client to shutdown.

commit 62f80529f5657223d792576686ddad6832d13506
Author: kkloudas <kkloudas@gmail.com>
Date:   2017-11-09T18:30:29Z

    [FLINK-7974][QS] Wait for QS abstract server to shutdown.

----


> AbstractServerBase#shutdown does not wait for shutdown completion
> -----------------------------------------------------------------
>
>                 Key: FLINK-7974
>                 URL: https://issues.apache.org/jira/browse/FLINK-7974
>             Project: Flink
>          Issue Type: Bug
>          Components: Queryable State
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>
> The {{AbstractServerBase}} does not wait for the completion of its shutdown when calling
{{AbstractServerBase#shutdown}}. This is problematic since it leads to resource leaks and
instable tests such as the {{AbstractServerTest}}. I propose to let the {{AbstractServerBase#shutdown}}
return a termination future which is completed upon shutdown completion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message