flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4998: [FLINK-7702] Add maven-bundle-plugin to root pom
Date Fri, 10 Nov 2017 23:02:30 GMT
GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4998

    [FLINK-7702] Add maven-bundle-plugin to root pom

    Before, we had it in places that require it. This doesn't work when
    running mvn javadoc:aggregate because this will only run for the root
    pom and can then not find the "bundle" dependencies.
    
    R: @zentol, could you maybe have a look.
    
    Before this change you couldn't run `mvn javadoc:aggregate -DadditionalJOption="-Xdoclint:none"
-Dmaven.javadoc.failOnError=false` successfully, meaning that we never actually built `1.4-SNAPSHOT`
Javadocs. With this change it seems to work but the `genjavadoc` tool that generates fake
Java sources from Scala code so that we can aggregate Javadocs also for Scala code doesn't
seem to work anymore on Scala 2.11.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-7702-fix-javadoc-build-with-genjava

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4998
    
----
commit caba0cbc36e8dd588e57c91c102c4fa097e6b5f6
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-11-10T17:13:26Z

    [FLINK-7702] Add maven-bundle-plugin to root pom
    
    Before, we had it in places that require it. This doesn't work when
    running mvn javadoc:aggregate because this will only run for the root
    pom and can then not find the "bundle" dependencies.

----


---

Mime
View raw message