From issues-return-140290-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Fri Nov 10 16:13:00 2017 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5CA2010726 for ; Fri, 10 Nov 2017 16:13:00 +0000 (UTC) Received: (qmail 45238 invoked by uid 500); 10 Nov 2017 16:13:00 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 45207 invoked by uid 500); 10 Nov 2017 16:13:00 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 45198 invoked by uid 99); 10 Nov 2017 16:13:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Nov 2017 16:13:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6DE291A0FF8 for ; Fri, 10 Nov 2017 16:12:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.521 X-Spam-Level: X-Spam-Status: No, score=-3.521 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LINKBAIT=0.5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id iFqpR1gMfhnF for ; Fri, 10 Nov 2017 16:12:59 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 82FF95F3BB for ; Fri, 10 Nov 2017 16:12:58 +0000 (UTC) Received: (qmail 44782 invoked by uid 99); 10 Nov 2017 16:12:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Nov 2017 16:12:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DF23ADFCBC; Fri, 10 Nov 2017 16:12:57 +0000 (UTC) From: NicoK To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3a defau... Content-Type: text/plain Message-Id: <20171110161257.DF23ADFCBC@git1-us-west.apache.org> Date: Fri, 10 Nov 2017 16:12:57 +0000 (UTC) Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4939 1) yes, I have tested the changes on a YARN cluster as described in the PR comment (before the changes on the unit tests) 2) regarding the `pom.xml` changes: I actually took those from 991af3652479f85f732cbbade46bed7df1c5d819 and 36b663f4561458408ee68902a1db6a5cd539e1c2 and can only guess why @StephanEwen and @zentol used this way except for what you proposed. Maybe they can clarify. ---