flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Fri, 01 Dec 2017 13:13:35 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154315390
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
    @@ -144,20 +147,19 @@ public void testReceiveBuffer() throws Exception {
     			inputGate.setBufferPool(bufferPool);
     			inputGate.assignExclusiveSegments(networkBufferPool, 2);
     
    -			final int backlog = 2;
    -			final BufferResponse bufferResponse = createBufferResponse(
    -				inputChannel.requestBuffer(), 0, inputChannel.getInputChannelId(), backlog);
    -
     			final CreditBasedClientHandler handler = new CreditBasedClientHandler();
     			handler.addInputChannel(inputChannel);
     
    +			final int backlog = 2;
    +			final BufferResponse bufferResponse = createBufferResponse(
    +				TestBufferFactory.createBuffer(32), 0, inputChannel.getInputChannelId(), backlog);
    --- End diff --
    
    good catch not getting the buffer from the channel here


---

Mime
View raw message