flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Fri, 01 Dec 2017 13:13:36 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154318828
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
    @@ -378,6 +381,11 @@ public void notifyBufferDestroyed() {
     		// Nothing to do actually.
     	}
     
    +	@VisibleForTesting
    +	public void increaseCredit(int credit) {
    --- End diff --
    
    I think we can live without this method that should never be called outside the tests
(since it modifies state): creating a `BufferResponse` with an appropriate backlog should
yield the same result in the tests


---

Mime
View raw message