flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...
Date Fri, 01 Dec 2017 13:38:12 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r154343510
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
    @@ -39,13 +39,15 @@
     	private final AtomicBoolean isReleased;
     
     	PipelinedSubpartitionView(PipelinedSubpartition parent, BufferAvailabilityListener listener)
{
    +		super(parent);
    +
     		this.parent = checkNotNull(parent);
     		this.availabilityListener = checkNotNull(listener);
     		this.isReleased = new AtomicBoolean();
     	}
     
     	@Override
    -	public Buffer getNextBuffer() {
    +	protected Buffer getNextBufferInternal() {
    --- End diff --
    
    Actually, a lot of the methods along these calls should probably be marked `@Nullable`.
Since you touched the `getNextBufferInternal()`, can you at least mark this (and maybe some
calls along the call stack if I say pretty please?). You can do so in a separate `[hotfix]`
commit to keep this separate


---

Mime
View raw message