flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...
Date Fri, 01 Dec 2017 13:38:32 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r154344942
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
    @@ -174,19 +175,21 @@ public ResultSubpartitionView answer(InvocationOnMock invocationOnMock)
throws T
     
     	// ---------------------------------------------------------------------------------------------
     
    -	static class InfiniteSubpartitionView implements ResultSubpartitionView {
    +	static class InfiniteSubpartitionView extends ResultSubpartitionView {
     
     		private final BufferProvider bufferProvider;
     
     		private final CountDownLatch sync;
     
     		public InfiniteSubpartitionView(BufferProvider bufferProvider, CountDownLatch sync)
{
    +			super(mock(ResultSubpartition.class));
    +
     			this.bufferProvider = checkNotNull(bufferProvider);
     			this.sync = checkNotNull(sync);
     		}
     
     		@Override
    -		public Buffer getNextBuffer() throws IOException, InterruptedException {
    +		protected Buffer getNextBufferInternal() throws IOException, InterruptedException {
    --- End diff --
    
    `@Nullable`


---

Mime
View raw message