flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...
Date Fri, 15 Dec 2017 13:15:14 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r156922694
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionViewTest.java
---
    @@ -48,8 +47,7 @@
     
     	private static final IOManager IO_MANAGER = new IOManagerAsync();
     
    -	private static final TestInfiniteBufferProvider writerBufferPool =
    -		new TestInfiniteBufferProvider();
    +	private static final TestPooledBufferProvider writerBufferPool = new TestPooledBufferProvider(Integer.MAX_VALUE);
    --- End diff --
    
    Good point. I have cleaned up/simplify this test a little bit more and dropped `TestPooledBufferProvider`
altogether to avoid this issue.


---

Mime
View raw message