flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...
Date Fri, 15 Dec 2017 13:15:15 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r156934340
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
---
    @@ -169,33 +151,29 @@ public Buffer getCurrentBuffer() {
     		if (targetBuffer == null) {
     			return null;
     		}
    -
    -		targetBuffer.setSize(position);
    -		return targetBuffer;
    +		Buffer result = targetBuffer.build();
    +		targetBuffer = null;
    +		return result;
    --- End diff --
    
    It kind of depends in which direction we will go with further changes.


---

Mime
View raw message