flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...
Date Fri, 15 Dec 2017 13:15:15 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r157178704
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
    @@ -118,7 +122,7 @@ public Buffer answer(InvocationOnMock invocation) throws Throwable
{
     			};
     
     			BufferProvider bufferProvider = mock(BufferProvider.class);
    -			when(bufferProvider.requestBufferBlocking()).thenAnswer(request);
    +			when(bufferProvider.requestBufferBuilderBlocking()).thenAnswer(request);
    --- End diff --
    
    This would require custom `BufferProvider` that would implement `final CountDownLatch
sync = new CountDownLatch(2);` logic (or expand `TestPooleBufferProvider`- this test relays
on waiting until one more call to `BufferProvider` after exhausting the pool happens.


---

Mime
View raw message