flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...
Date Fri, 15 Dec 2017 13:15:20 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r157174669
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
    @@ -188,10 +189,16 @@ public Buffer requestBuffer() throws IOException {
     
     	@Override
     	public Buffer requestBufferBlocking() throws IOException, InterruptedException {
    -		return requestBuffer(true);
    +		BufferBuilder bufferBuilder = requestBufferBuilder(true);
    +		return bufferBuilder != null ? bufferBuilder.build() : null;
    --- End diff --
    
    ditto, this path would require changing `BufferOrEvent` to `BufferBuilderOrEvent`.


---

Mime
View raw message