flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients
Date Fri, 15 Dec 2017 18:46:49 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5076#discussion_r157271859
  
    --- Diff: pom.xml ---
    @@ -891,6 +905,41 @@ under the License.
     
     	<build>
     		<plugins>
    +			<plugin>
    +				<groupId>org.apache.maven.plugins</groupId>
    +				<artifactId>maven-dependency-plugin</artifactId>
    +				<version>3.0.2</version>
    +				<executions>
    +					<execution>
    +						<id>analyze</id>
    +						<goals>
    +							<goal>analyze-only</goal>
    +						</goals>
    +						<configuration>
    +							<!-- Ignore runtime-only dependencies in analysis -->
    +							<ignoreNonCompile>true</ignoreNonCompile>
    +							<outputXML>true</outputXML>
    +							<failOnWarning>true</failOnWarning>
    +							<ignoredUnusedDeclaredDependencies>
    --- End diff --
    
    Can we keep the root dependencies? I find the current way actually convenient and avoiding
pom clutter.
    
    As Chesnay mentioned, the compile scope dependencies should be okay (used everywhere).
    
    Could the test dependencies be separately skipped? 


---

Mime
View raw message