flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based
Date Fri, 01 Dec 2017 13:39:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274405#comment-16274405

ASF GitHub Bot commented on FLINK-7468:

Github user NicoK commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
    @@ -39,13 +39,15 @@
     	private final AtomicBoolean isReleased;
     	PipelinedSubpartitionView(PipelinedSubpartition parent, BufferAvailabilityListener listener)
    +		super(parent);
     		this.parent = checkNotNull(parent);
     		this.availabilityListener = checkNotNull(listener);
     		this.isReleased = new AtomicBoolean();
    -	public Buffer getNextBuffer() {
    +	protected Buffer getNextBufferInternal() {
    --- End diff --
    Actually, a lot of the methods along these calls should probably be marked `@Nullable`.
Since you touched the `getNextBufferInternal()`, can you at least mark this (and maybe some
calls along the call stack if I say pretty please?). You can do so in a separate `[hotfix]`
commit to keep this separate

> Implement sender backlog logic for credit-based
> -----------------------------------------------
>                 Key: FLINK-7468
>                 URL: https://issues.apache.org/jira/browse/FLINK-7468
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the backlog).
The receivers use this information to decide how to distribute floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the number of buffers
in this subpartition, not including the number of events. The backlog is increased for adding
buffer to this subpartition, and decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value after the
buffer being transferred.

This message was sent by Atlassian JIRA

View raw message