flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder
Date Fri, 15 Dec 2017 13:16:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292512#comment-16292512
] 

ASF GitHub Bot commented on FLINK-8178:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r157172734
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
    @@ -179,7 +179,8 @@ public void setBufferPoolOwner(BufferPoolOwner owner) {
     	@Override
     	public Buffer requestBuffer() throws IOException {
     		try {
    -			return requestBuffer(false);
    +			BufferBuilder bufferBuilder = requestBufferBuilder(false);
    +			return bufferBuilder != null ? bufferBuilder.build() : null;
    --- End diff --
    
    Nope, size is always set manually in remaining calls.
    
    Yes I know, but it took me almost a week to adapt tests so far for this `BufferBuilder`
(and `requestBuffer` is mocked ~60 times...). Can we postpone finishing this refactor for
a later time? 


> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
>                 Key: FLINK-8178
>                 URL: https://issues.apache.org/jira/browse/FLINK-8178
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires synchronisation. Now
it is miss-leading/unclear and suggesting that RecordSerializer should take into account synchronisation
of the Buffer that's holding. With NotThreadSafe BufferBuilder there would be clear separation
between single-threaded writing/creating a BufferBuilder and multithreaded Buffer handling/retaining/recycling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message