flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder
Date Fri, 15 Dec 2017 13:16:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292516#comment-16292516
] 

ASF GitHub Bot commented on FLINK-8178:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r157178704
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
    @@ -118,7 +122,7 @@ public Buffer answer(InvocationOnMock invocation) throws Throwable
{
     			};
     
     			BufferProvider bufferProvider = mock(BufferProvider.class);
    -			when(bufferProvider.requestBufferBlocking()).thenAnswer(request);
    +			when(bufferProvider.requestBufferBuilderBlocking()).thenAnswer(request);
    --- End diff --
    
    This would require custom `BufferProvider` that would implement `final CountDownLatch
sync = new CountDownLatch(2);` logic (or expand `TestPooleBufferProvider`- this test relays
on waiting until one more call to `BufferProvider` after exhausting the pool happens.


> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
>                 Key: FLINK-8178
>                 URL: https://issues.apache.org/jira/browse/FLINK-8178
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires synchronisation. Now
it is miss-leading/unclear and suggesting that RecordSerializer should take into account synchronisation
of the Buffer that's holding. With NotThreadSafe BufferBuilder there would be clear separation
between single-threaded writing/creating a BufferBuilder and multithreaded Buffer handling/retaining/recycling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message