flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...
Date Tue, 02 Jan 2018 13:18:20 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5230#discussion_r159222752
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
---
    @@ -586,7 +586,7 @@ private StreamGraph generateInternal(List<StreamTransformation<?>>
transformatio
     				transform.getOutputType(),
     				transform.getName());
     
    -		if (transform.getStateKeySelector1() != null) {
    +		if (transform.getStateKeySelector1() != null || transform.getStateKeySelector2() !=
null) {
    --- End diff --
    
    Do we still need the check here or will the code work if we set either to `null`? I think
it does because in the broadcast case we set the second key selector to `null`.


---

Mime
View raw message