flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability
Date Tue, 02 Jan 2018 14:33:26 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5193#discussion_r159222250
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/TaskTestBase.java
---
    @@ -145,19 +145,7 @@ public MemoryManager getMemoryManager() {
     	}
     
     	@After
    -	public void shutdownIOManager() throws Exception {
    -		this.mockEnv.getIOManager().shutdown();
    -		Assert.assertTrue("IO Manager has not properly shut down.", this.mockEnv.getIOManager().isProperlyShutDown());
    -	}
    -
    -	@After
    -	public void shutdownMemoryManager() throws Exception {
    -		if (this.memorySize > 0) {
    --- End diff --
    
    No, it didn't matter so I allowed myself to simplify this shutdown. But good catch. I
was thinking about doing this simplification in separate commit so that there would be no
need for "catching" this behaviour change. 


---

Mime
View raw message