flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...
Date Wed, 03 Jan 2018 23:00:33 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4963#discussion_r159549032
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/ListState.java ---
    @@ -33,4 +35,14 @@
      * @param <T> Type of values that this list state keeps.
      */
     @PublicEvolving
    -public interface ListState<T> extends MergingState<T, Iterable<T>>
{}
    +public interface ListState<T> extends MergingState<T, Iterable<T>>
{
    +	/**
    +	 * Updates the state of the current key for the given source namespaces into the state
of
    +	 * the target namespace.
    +	 *
    +	 * @param values The target namespace where the merged state should be stored.
    +	 *
    +	 * @throws Exception The method may forward exception thrown internally (by I/O or functions).
    +	 */
    +	void update(List<T> values) throws Exception;
    --- End diff --
    
    We should define and document what happens if this is called with `null` or empty list.
Does this lead to different results for `get()` ?


---

Mime
View raw message