flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5140: [FLINK-7797] [table] Add support for windowed oute...
Date Thu, 04 Jan 2018 18:16:09 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159697015
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
    @@ -288,34 +276,37 @@ abstract class TimeBoundedStreamJoin(
             if (leftTime >= leftQualifiedLowerBound && leftTime <= leftQualifiedUpperBound)
{
               val leftRows = leftEntry.getValue
               var i = 0
    -          var markEmitted = false
    +          var entryUpdated = false
               while (i < leftRows.size) {
    -            joinCollector.resetThisTurn()
    +            joinCollector.reset()
                 val tuple = leftRows.get(i)
                 joinFunction.join(tuple.f0, rightRow, joinCollector)
    -            if (joinType == JoinType.LEFT_OUTER || joinType == JoinType.FULL_OUTER) {
    -              if (!tuple.f1 && joinCollector.everEmittedThisTurn) {
    -                // Mark the left row as being successfully joined and emitted.
    -                tuple.f1 = true
    -                markEmitted = true
    +            if (joinCollector.emitted) {
    --- End diff --
    
    same as for `processElement1()`


---

Mime
View raw message