flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability
Date Thu, 04 Jan 2018 18:40:24 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5193#discussion_r159724744
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java
---
    @@ -383,7 +383,10 @@ public void failExternally(Throwable cause) {
     
     	@Override
     	public void close() {
    -		checkState(memManager.verifyEmpty(), "Memory Manager managed memory was not completely
freed.");
    +		// close() method should be idempotent and calling memManager.verifyEmpty() will thow
after it was shutdown.
    --- End diff --
    
    nit: typo "throw"


---

Mime
View raw message