flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...
Date Mon, 08 Jan 2018 10:36:39 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r160110253
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java
---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.jobmaster;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.dispatcher.Dispatcher;
    +import org.apache.flink.util.SerializedThrowable;
    +import org.apache.flink.util.SerializedValue;
    +
    +import javax.annotation.Nullable;
    +
    +import java.util.Collections;
    +import java.util.Map;
    +import java.util.Optional;
    +
    +import static java.util.Objects.requireNonNull;
    +import static org.apache.flink.util.Preconditions.checkArgument;
    +
    +/**
    + * Similar to {@link org.apache.flink.api.common.JobExecutionResult} but with an optional
    + * {@link SerializedThrowable} when the job failed.
    + *
    + * <p>This is used by the {@link JobMaster} to send the results to the {@link Dispatcher}.
    + */
    +public class JobExecutionResult {
    --- End diff --
    
    Could be made `Serializable` especially if the `JobMaster` should run in the future on
a different machine.


---

Mime
View raw message