flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...
Date Mon, 08 Jan 2018 10:36:40 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r160108633
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
    @@ -405,22 +407,27 @@ private void decrementCheckAndCleanup() {
     
     		private volatile Throwable runnerException;
     
    -		private volatile JobExecutionResult result;
    +		private volatile org.apache.flink.runtime.jobmaster.JobExecutionResult result;
     		
     		BlockingJobSync(JobID jobId, int numJobMastersToWaitFor) {
     			this.jobId = jobId;
     			this.jobMastersToWaitFor = new CountDownLatch(numJobMastersToWaitFor);
     		}
     
     		@Override
    -		public void jobFinished(JobExecutionResult jobResult) {
    -			this.result = jobResult;
    +		public void jobFinished(org.apache.flink.runtime.jobmaster.JobExecutionResult result)
{
    +			this.result = result;
     			jobMastersToWaitFor.countDown();
     		}
     
     		@Override
    -		public void jobFailed(Throwable cause) {
    -			jobException = cause;
    +		public void jobFailed(org.apache.flink.runtime.jobmaster.JobExecutionResult result)
{
    +			checkArgument(result.getSerializedThrowable().isPresent());
    +
    +			jobException = result
    --- End diff --
    
    Then I guess that we should remove it and store instead the `jobmaster.JobExecutionResult`.
      


---

Mime
View raw message